[PATCH v2 7/7] power_supply: make use of new strcpytoupper() function

From	Markus Mayer <mmayer@broadcom.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 7/7] power_supply: make use of new strcpytoupper() function
Date	2016-07-05 22:50 +0200
Message-ID	<rRFs5-7Ol-13@gated-at.bofh.it> (permalink)
References	<rRFs5-7Ol-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Call strcpytoupper() rather than walking the string explicitly to
convert it to uppercase.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
 drivers/power/power_supply_sysfs.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 80fed98..20fdcc5 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -256,19 +256,16 @@ void power_supply_init_attrs(struct device_type *dev_type)
 
 static char *kstruprdup(const char *str, gfp_t gfp)
 {
-	char *ret, *ustr;
+	char *ustr;
 
-	ustr = ret = kmalloc(strlen(str) + 1, gfp);
+	ustr = kmalloc(strlen(str) + 1, gfp);
 
-	if (!ret)
+	if (!ustr)
 		return NULL;
 
-	while (*str)
-		*ustr++ = toupper(*str++);
+	strcpytoupper(ustr, str);
 
-	*ustr = 0;
-
-	return ret;
+	return ustr;
 }
 
 int power_supply_uevent(struct device *dev, struct kobj_uevent_env *env)
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 7/7] power_supply: make use of new strcpytoupper() function Markus Mayer <mmayer@broadcom.com> - 2016-07-05 22:50 +0200

csiph-web