Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue
Date	2016-07-05 23:10 +0200
Message-ID	<rRFLs-8bM-23@gated-at.bofh.it> (permalink)
References	<rQqY9-2RL-5@gated-at.bofh.it> <rQtt0-4cj-3@gated-at.bofh.it> <rR3d7-zy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote:
> On 02.07.2016 22:46, Tejun Heo wrote:
> > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote:
> >> alloc_workqueue replaces deprecated create_singlethread_workqueue().
> >>
> >> A dedicated workqueue has been used since work items need to be flushed
> >> as a group rather than individually.

There seem to be two work items involved, the flip one and unpin one.
Provided that there's no ordering requirement between the two, can't
we just flush them individually?

> >> Since the flip_queue workqueue is involved in page-flipping and is not
> >> being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set.
> >>
> >> Since there are only a fixed number of work items, explicit concurrency
> >> limit is unnecessary here.
> > 
> > What are the involved work items?
> 
> drivers/gpu/drm/radeon/radeon_display.c:radeon_flip_work_func()
>
> > Is it safe to run them concurrently?
> 
> Concurrently with what exactly?

The flip and unpin work items.

Thanks.

-- 
tejun

Thread

[PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-02 13:10 +0200
  Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-02 15:50 +0200
    Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Michel Dänzer <michel@daenzer.net> - 2016-07-04 06:00 +0200
      Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-05 23:10 +0200
        Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Michel Dänzer <michel@daenzer.net> - 2016-07-06 05:20 +0200
          Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-06 15:50 +0200
            Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Michel Dänzer <michel@daenzer.net> - 2016-07-07 06:20 +0200
              Re: [PATCH] drm/radeon: Remove deprecated  create_singlethread_workqueue Michel Dänzer <michel@daenzer.net> - 2016-07-08 08:00 +0200

csiph-web