Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437123

Re: [PATCH] gpio: of: Allow overriding the device node

Show all headers | View raw

On Tue, Jul 5, 2016 at 2:11 PM, Thierry Reding <thierry.reding@gmail.com> wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> When registering a GPIO chip, drivers can override the device tree node
> associated with the chip by setting the chip's ->of_node field. If set,
> this field is supposed to take precedence over the ->parent->of_node
> field, but the code doesn't actually do that.
>
> Commit 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and
> struct gg_data") exposes this because it now no longer matches on the
> GPIO chip's ->of_node field, but the GPIO device's ->of_node field that
> is set using the procedure described above.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Thanks for catching this, patch applied with Alexandre's ACK.

Masahiro: does this look all right to you?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: of: Allow overriding the device node Thierry Reding <thierry.reding@gmail.com> - 2016-07-05 14:20 +0200
  Re: [PATCH] gpio: of: Allow overriding the device node Alexandre Courbot <gnurou@gmail.com> - 2016-07-05 15:20 +0200
  Re: [PATCH] gpio: of: Allow overriding the device node Linus Walleij <linus.walleij@linaro.org> - 2016-07-05 17:30 +0200
    Re: [PATCH] gpio: of: Allow overriding the device node Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-06 03:10 +0200
      Re: [PATCH] gpio: of: Allow overriding the device node Linus Walleij <linus.walleij@linaro.org> - 2016-07-06 11:10 +0200

csiph-web