Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Andi Shyti <andi@etezian.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI
Date	Tue, 05 Jul 2016 17:10:01 +0200
Message-ID	<rRA93-4vb-5@gated-at.bofh.it> (permalink)
References	<rQ29s-4m1-43@gated-at.bofh.it> <rRzwm-3YJ-31@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Andi Shyti <andi.shyti@samsung.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
X-Original-Date	Wed, 6 Jul 2016 00:08:26 +0900
X-Original-Message-ID	<20160705150826.GG1257@jack.zhora.eu>
X-Original-References	<1467362022-12704-1-git-send-email-andi.shyti@samsung.com> <20160705142211.GA19930@rob-hp-laptop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1437106

Show key headers only | View raw

Hi Rob,

> > The ir-spi is a simple device driver which supports the
> > connection between an IR LED and the MOSI line of an SPI device.
> 
> Please split the binding from the driver.

OK!

> > +Device tree bindings for IR LED connected through SPI bus which is used as
> > +remote controller.
> 
> Do said devices have part numbers? Seems kind of generic and I've never 
> seen such device.

No, it doesn't, this is a simple irled driven by the SPI MOSI
line that works as a remote controller.

It looked strange to me as well when I heard of it the first
time, but it will be present in the upcoming tm2/tm2e patchset 
(i.e. Samsung Note 4 and Note 4 edge).

> > +Optional properties:
> > +	- irled,switch: specifies the gpio switch which enables the irled
> 
> Just "switch-gpios"

OK!

> > +                controller-data {
> 
> This is part of the controller binding? Omit that from the example.

OK!

Thanks,
Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI Andi Shyti <andi.shyti@samsung.com> - 2016-07-01 10:40 +0200
  Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI Sean Young <sean@mess.org> - 2016-07-01 11:50 +0200
    Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with  SPI Andi Shyti <andi.shyti@samsung.com> - 2016-07-01 14:40 +0200
      Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI Sean Young <sean@mess.org> - 2016-07-01 15:30 +0200
        Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI Andi Shyti <andi@etezian.org> - 2016-07-01 16:10 +0200
  Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI kbuild test robot <lkp@intel.com> - 2016-07-02 07:00 +0200
  Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI Rob Herring <robh@kernel.org> - 2016-07-05 16:30 +0200
    Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected  with SPI Andi Shyti <andi@etezian.org> - 2016-07-05 17:10 +0200

csiph-web