Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis
Date	2016-07-04 12:40 +0200
Message-ID	<rR9sd-4tf-27@gated-at.bofh.it> (permalink)
References	<rR8Zc-4jv-23@gated-at.bofh.it> <rR8Zc-4jv-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 04, 2016 at 06:08:27PM +0800, Hillf Danton wrote:
> > @@ -2561,17 +2580,23 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> >  	 * highmem pages could be pinning lowmem pages storing buffer_heads
> >  	 */
> >  	orig_mask = sc->gfp_mask;
> > -	if (buffer_heads_over_limit)
> > +	if (buffer_heads_over_limit) {
> >  		sc->gfp_mask |= __GFP_HIGHMEM;
> > +		sc->reclaim_idx = classzone_idx = gfp_zone(sc->gfp_mask);
> > +	}
> > 
> We need to push/pop ->reclaim_idx as ->gfp_mask handled?
> 

I saw no harm in having one full reclaim attempt reclaiming from all
zones if buffer_heads_over_limit was triggered. If it fails, the page
allocator will loop again and reset the reclaim_idx.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-07-04 12:10 +0200
  Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node  basis Mel Gorman <mgorman@techsingularity.net> - 2016-07-04 12:40 +0200

csiph-web