[RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock

From	Alim Akhtar <alim.akhtar@samsung.com>
Newsgroups	linux.kernel
Subject	[RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock
Date	2016-07-04 13:10 +0200
Message-ID	<rR9Vg-4SC-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc
clock already disabled, which looks extra and unnecessary call.
Lets clean it up.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 drivers/rtc/rtc-s3c.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index d01ad7e..b083840 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -577,8 +577,6 @@ static int s3c_rtc_probe(struct platform_device *pdev)
 
 	s3c_rtc_setfreq(info, 1);
 
-	s3c_rtc_disable_clk(info);
-
 	return 0;
 
  err_nortc:
-- 
1.7.10.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already  disabled clock Alim Akhtar <alim.akhtar@samsung.com> - 2016-07-04 13:10 +0200
  Re: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable  already disabled clock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-05 09:20 +0200
    Re: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable  already disabled clock Alim Akhtar <alim.akhtar@samsung.com> - 2016-07-05 10:50 +0200
      Re: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable  already disabled clock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-05 11:00 +0200

csiph-web