Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436398

Re: [PATCH 1/1] thermal: qcom: remove declare local symbols as static

Show all headers | View raw

On 7/2/2016 6:33 AM, Eduardo Valentin wrote:
> Trivial: remove the following:
> drivers/thermal/qcom/tsens-8916.c:103:24: warning: symbol 'ops_8916' was not declared. Should it be static?
> drivers/thermal/qcom/tsens-8996.c:76:24: warning: symbol 'ops_8996' was not declared. Should it be static?
> drivers/thermal/qcom/tsens-8974.c:235:24: warning: symbol 'ops_8974' was not declared. Should it be static?
> drivers/thermal/qcom/tsens-8960.c:279:24: warning: symbol 'ops_8960' was not declared. Should it be static?

Thanks for fixing this,
Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org>

>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
> ---
>   drivers/thermal/qcom/tsens-8916.c | 2 +-
>   drivers/thermal/qcom/tsens-8960.c | 2 +-
>   drivers/thermal/qcom/tsens-8974.c | 2 +-
>   drivers/thermal/qcom/tsens-8996.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-8916.c b/drivers/thermal/qcom/tsens-8916.c
> index beb3afa..fdf561b 100644
> --- a/drivers/thermal/qcom/tsens-8916.c
> +++ b/drivers/thermal/qcom/tsens-8916.c
> @@ -100,7 +100,7 @@ static int calibrate_8916(struct tsens_device *tmdev)
>   	return 0;
>   }
>
> -const struct tsens_ops ops_8916 = {
> +static const struct tsens_ops ops_8916 = {
>   	.init		= init_common,
>   	.calibrate	= calibrate_8916,
>   	.get_temp	= get_temp_common,
> diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c
> index 1d60916..0451277 100644
> --- a/drivers/thermal/qcom/tsens-8960.c
> +++ b/drivers/thermal/qcom/tsens-8960.c
> @@ -276,7 +276,7 @@ static int get_temp_8960(struct tsens_device *tmdev, int id, int *temp)
>   	return -ETIMEDOUT;
>   }
>
> -const struct tsens_ops ops_8960 = {
> +static const struct tsens_ops ops_8960 = {
>   	.init		= init_8960,
>   	.calibrate	= calibrate_8960,
>   	.get_temp	= get_temp_8960,
> diff --git a/drivers/thermal/qcom/tsens-8974.c b/drivers/thermal/qcom/tsens-8974.c
> index da3ca4c..9baf77e 100644
> --- a/drivers/thermal/qcom/tsens-8974.c
> +++ b/drivers/thermal/qcom/tsens-8974.c
> @@ -232,7 +232,7 @@ static int calibrate_8974(struct tsens_device *tmdev)
>   	return 0;
>   }
>
> -const struct tsens_ops ops_8974 = {
> +static const struct tsens_ops ops_8974 = {
>   	.init		= init_common,
>   	.calibrate	= calibrate_8974,
>   	.get_temp	= get_temp_common,
> diff --git a/drivers/thermal/qcom/tsens-8996.c b/drivers/thermal/qcom/tsens-8996.c
> index e2e1274..e1f7781 100644
> --- a/drivers/thermal/qcom/tsens-8996.c
> +++ b/drivers/thermal/qcom/tsens-8996.c
> @@ -73,7 +73,7 @@ done:
>   	return 0;
>   }
>
> -const struct tsens_ops ops_8996 = {
> +static const struct tsens_ops ops_8996 = {
>   	.init		= init_common,
>   	.get_temp	= get_temp_8996,
>   };
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] thermal: qcom: remove declare local symbols as static Eduardo Valentin <edubezval@gmail.com> - 2016-07-02 03:10 +0200
  Re: [PATCH 1/1] thermal: qcom: remove declare local symbols as static "Nayak, Rajendra" <rnayak@codeaurora.org> - 2016-07-04 11:40 +0200

csiph-web