RE: [PATCH 2/7] arm: mach-shmobile: pm-rmobile: add missing of_node_put after calling of_parse_phandle

From	Peter Chen <peter.chen@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/7] arm: mach-shmobile: pm-rmobile: add missing of_node_put after calling of_parse_phandle
Date	2016-07-04 09:50 +0200
Message-ID	<rR6NH-2Pw-7@gated-at.bofh.it> (permalink)
References	<rQ41z-5v6-9@gated-at.bofh.it> <rQ5TI-6DF-7@gated-at.bofh.it> <rQ5TI-6DF-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

 
>On Fri, Jul 1, 2016 at 11:41 AM, Peter Chen <peter.chen@nxp.com> wrote:
>> of_node_put needs to be called when the device node which is got from
>> of_parse_phandle has finished using.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Signed-off-by: Peter Chen <peter.chen@nxp.com>
>
>NAKed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm/mach-shmobile/pm-rmobile.c
>> +++ b/arch/arm/mach-shmobile/pm-rmobile.c
>> @@ -209,6 +209,7 @@ static void __init add_special_pd(struct device_node *np,
>enum pd_types type)
>>         special_pds[num_special_pds].pd = pd;
>
>The pd pointer is stored in the line above, and released later in put_special_pds().
>
>>         special_pds[num_special_pds].type = type;
>>         num_special_pds++;
>> +       of_node_put(pd);
>
>Hence it must not be released here, as that would cause a double release when
>put_special_pds() is executed.
>

Thanks, Geert, it is my careless.

Please forget this patch.

Peter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/7] arm: mach-shmobile: pm-rmobile: add missing  of_node_put after calling of_parse_phandle Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-01 14:40 +0200
  RE: [PATCH 2/7] arm: mach-shmobile: pm-rmobile: add missing  of_node_put after calling of_parse_phandle Peter Chen <peter.chen@nxp.com> - 2016-07-04 09:50 +0200

csiph-web