Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436407

Re: [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks

Show all headers | View raw

Hi Andi,

2016-06-30 16:15 GMT+09:00 Andi Shyti <andi.shyti@samsung.com>:
> Hi,
>
> This patchset enables spi3 clocks by marking critical clocks as
> CLK_IS_CRITICAL and in the meantime replaces the use of
> CLK_IGNORE_UNUSED for spi1 clocks.
>
> The sclk needs to be considered critical as well.
>
> The SPI3 in the tm2/tm2e boards will control an irled for remote
> controlling.
>
> Changelog:
>
> V1 -> V2
>  - the "sclk_spi3" doesn't need to be enabled in boot time as it
>   is handled by the spi driver itself.
>
>  - use the CLK_IS_CRITICAL flag for the ioclk
>
> V2 -> V3
>  - some more tests has confirmed taht "sclk_spi1,3" need to be
>    enabled as critical!

This sounds like a DTS and/or SPI and/or clock driver bug then. I'm
pretty much convinced that it might also cause other problems and this
workaround will only mask them making things even more difficult to
debug in the future. Let's not introduce more technical debt.

Best regards,
Tomasz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Andi Shyti <andi.shyti@samsung.com> - 2016-06-30 09:30 +0200
  [PATCH v3 2/2] clk: exynos5433: enable sclk_ioclk for SPI3 Andi Shyti <andi.shyti@samsung.com> - 2016-06-30 09:30 +0200
  Re: [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-07-04 06:10 +0200
    Re: [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Andi Shyti <andi.shyti@samsung.com> - 2016-07-04 06:30 +0200
      Re: [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-07-04 07:00 +0200

csiph-web