Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436105

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

Show all headers | View raw

On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer <markus.mayer@broadcom.com> wrote:
> On 1 July 2016 at 18:18, Alexandre Courbot <gnurou@gmail.com> wrote:
>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer@broadcom.com> wrote:
>>> Call strtolower() rather than walking the string explicitly to convert
>>> it to lowercase.
>>>
>>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>>> ---
>>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------
>>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> index 34ecd4a..c50594c 100644
>>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname,
>>>  {
>>>         char f[64];
>>>         char cname[16];
>>> -       int i;
>>>
>>>         /* Convert device name to lowercase */
>>>         strncpy(cname, device->chip->name, sizeof(cname));
>>>         cname[sizeof(cname) - 1] = '\0';
>>> -       i = strlen(cname);
>>> -       while (i) {
>>> -               --i;
>>> -               cname[i] = tolower(cname[i]);
>>> -       }
>>> +       strtolower(cname);
>>
>> This function doesn't seem to exist as of next-20160701, where have
>> you found it?
>
> I didn't find it. I wrote it, because it didn't exist and I needed it.
> See: https://lkml.org/lkml/2016/6/30/727 and
> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
> series).

Ah, right - would have been easier to understand if you had sent the
whole series (or at least patches 0 to 2) to us as well. Please do
that for the next version.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] lib: string: add function strtolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
  [PATCH 4/6] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
    Re: [PATCH 4/6] ACPI / device_sysfs: make use of new strtolower() function "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-01 22:50 +0200
  [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
    Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new  strtolower() function Alexandre Courbot <gnurou@gmail.com> - 2016-07-02 03:20 +0200
      Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new  strtolower() function Markus Mayer <markus.mayer@broadcom.com> - 2016-07-02 17:30 +0200
        Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new  strtolower() function Alexandre Courbot <gnurou@gmail.com> - 2016-07-04 03:40 +0200
          Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new  strtolower() function Alexandre Courbot <gnurou@gmail.com> - 2016-07-04 05:50 +0200
  [PATCH 3/6] ACPICA: make use of new strtolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
    RE: [PATCH 3/6] ACPICA: make use of new strtolower() function "Moore, Robert" <robert.moore@intel.com> - 2016-07-01 03:20 +0200
      Re: [PATCH 3/6] ACPICA: make use of new strtolower() function Markus Mayer <markus.mayer@broadcom.com> - 2016-07-01 06:20 +0200
        RE: [PATCH 3/6] ACPICA: make use of new strtolower() function "Moore, Robert" <robert.moore@intel.com> - 2016-07-01 06:40 +0200
  [PATCH 5/6] staging: speakup: replace spk_strlwr() with strtolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
    Re: [PATCH 5/6] staging: speakup: replace spk_strlwr() with  strtolower() Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-07-01 02:40 +0200
  [PATCH 1/6] lib: string: add function strtolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-01 02:00 +0200
    Re: [PATCH 1/6] lib: string: add function strtolower() Jani Nikula <jani.nikula@linux.intel.com> - 2016-07-01 13:00 +0200
      Re: [PATCH 1/6] lib: string: add function strtolower() Markus Mayer <markus.mayer@broadcom.com> - 2016-07-01 19:20 +0200
        Re: [PATCH 1/6] lib: string: add function strtolower() Jani Nikula <jani.nikula@linux.intel.com> - 2016-07-01 19:40 +0200
    Re: [PATCH 1/6] lib: string: add function strtolower() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-07-01 23:10 +0200
      Re: [PATCH 1/6] lib: string: add function strtolower() Markus Mayer <markus.mayer@broadcom.com> - 2016-07-04 22:20 +0200

csiph-web