Re: [PATCHv3] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify
Date	2016-07-02 20:20 +0200
Message-ID	<rQxGi-6Qh-7@gated-at.bofh.it> (permalink)
References	<rQxGi-6Qh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/07/16 18:00, Nicholas Krause wrote:
> This adds properly checking after the call to mvs_find_dev_mvi
>  due to this function being able to return a NULL pointer and
> if this does arise we will deference it in mvs_alloc_dev due
> to this function never checking if a NULL pointer is given as
> it's input argument. Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> v3 - Make logic simpler on error path by returning -1 directly
> if mvs_find_dev_mvi returns NULL.
> v2 - Fix NULL pointer deferenece in error path by calling 
> spin_unlock_irqrestore on the now NULL pointer, as returned
> 
> 
>  drivers/scsi/mvsas/mv_sas.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index 5b9fcff..dffab01 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -1194,6 +1194,8 @@ int mvs_dev_found_notify(struct domain_device *dev, int lock)
>  	struct mvs_device *mvi_device;
>  
>  	mvi = mvs_find_dev_mvi(dev);
> +	if (!mvi)
> +		return -1;
>  
>  	if (lock)
>  		spin_lock_irqsave(&mvi->lock, flags);
> 

This looks better :)

Checking the value of mvi makes sense if mvs_find_dev_mvi() can return NULL.

Reviewed-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Thanks,
Luis

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-02 20:20 +0200
  Re: [PATCHv3] mvsas:Fix possible NULL pointer deference in  mvs_dev_found_notify James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-07-02 21:10 +0200
    Re: [PATCHv3] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-03 16:00 +0200

csiph-web