Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation
Date	2016-07-02 15:50 +0200
Message-ID	<rQtt0-4cj-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rQpfH-1GJ-7@gated-at.bofh.it> <rQpz4-1Nb-21@gated-at.bofh.it> <rQqY9-2RL-13@gated-at.bofh.it> <rQrAR-359-3@gated-at.bofh.it> <rQtjj-48Z-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Jul 02, 2016 at 03:32:43PM +0200, Alexandre Belloni wrote:
> > > > I believe that the best way to deal with this is to add an
> > > > "allwinner,general-purpose-mode" flag to the existing binding
> > > > (as well as document general purpose mode in the existing
> > > > binding rather then in a new binding doc).
> > > > 
> > > > That seems to be the right thing to do purely looking at this
> > > > from a dt binding pov.
> > > 
> > > There's a way simpler solution: if there's no child nodes, it's meant
> > > to be used as an ADC, otherwise, as input.
> > > 
> > > The logic will have to be a bit more complex than that, since there's
> > > two channels, and you could only require one for the buttons, leaving
> > > the other one available as an ADC.
> > > 
> > > But that doesn't require any new property.
> > 
> > True, if there are no button nodes, then go general-purpose will
> > work too.
> 
> Well, I'd still argue that we need two different compatibles because
> encoding the usage of an IP in its compatible string is less than ideal.

That's true, but it's what we have.

So feel free to add a new compatible if you want, but we'll have to
support the old one anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thread

[PATCH 1/2] iio: sun4i-lradc: Add binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-01 23:10 +0200
  Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Chen-Yu Tsai <wens@csie.org> - 2016-07-02 11:20 +0200
    Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Hans de Goede <hdegoede@redhat.com> - 2016-07-02 11:40 +0200
      Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-02 13:10 +0200
        Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Hans de Goede <hdegoede@redhat.com> - 2016-07-02 13:50 +0200
          Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-02 15:40 +0200
            Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-02 15:50 +0200
    Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-02 15:40 +0200
      Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Hans de Goede <hdegoede@redhat.com> - 2016-07-02 21:50 +0200
        Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-02 22:50 +0200
      Re: [PATCH 1/2] iio: sun4i-lradc: Add binding documentation Jonathan Cameron <jic23@kernel.org> - 2016-07-03 14:10 +0200

csiph-web