Re: [PATCH] [media] adv7842: Remove deprecated create_singlethread_workqueue

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] adv7842: Remove deprecated create_singlethread_workqueue
Date	2016-07-02 15:10 +0200
Message-ID	<rQsQh-3Zy-3@gated-at.bofh.it> (permalink)
References	<rQqv7-2sO-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 02, 2016 at 04:07:22PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "work_queues" enables hotplugging.
> It has a single work item(&state->delayed_work_enable_hotplug) and hence
> doesn't require ordering. Also, it is not being used on a memory
> reclaim path. Hence, the singlethreaded workqueue has been replaced with
> the use of system_wq.
> 
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
> 
> Work item has been sync cancelled in adv7842_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] adv7842: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-02 12:40 +0200
  Re: [PATCH] [media] adv7842: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-02 15:10 +0200

csiph-web