Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1435526

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

Show all headers | View raw

Hi,

On Thu, Jun 30, 2016 at 3:21 PM, Brian Norris <briannorris@chromium.org> wrote:
> The PCIe driver didn't mask the host interrupts before trying to tear
> down. This causes lockups at reboot or rmmod when using MSI-X on 8997,
> since the MSI handler gets confused and locks up the system.
>
> Also tested on 8897, which does not support MSI-X (and wasn't
> experiencing this same bug). No regressions seen there.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++
>  1 file changed, 6 insertions(+)

This looks very sane but isn't my area of expertise at all.  However,
if my Reviewed-by is at all useful feel free to add it.  I will say
that this fixes the issue of the crash at reboot time, so at least
I'll add:

Tested-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mwifiex: mask PCIe interrupts before removal Brian Norris <briannorris@chromium.org> - 2016-07-01 00:30 +0200
  Re: [PATCH] mwifiex: mask PCIe interrupts before removal Doug Anderson <dianders@chromium.org> - 2016-07-01 19:50 +0200
  Re: [PATCH] mwifiex: mask PCIe interrupts before removal Brian Norris <briannorris@chromium.org> - 2016-07-07 20:20 +0200
    Re: [PATCH] mwifiex: mask PCIe interrupts before removal Kalle Valo <kvalo@codeaurora.org> - 2016-07-07 21:40 +0200
  Re: mwifiex: mask PCIe interrupts before removal Kalle Valo <kvalo@codeaurora.org> - 2016-07-08 15:50 +0200

csiph-web