Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in psif_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in psif_probe()
Date	2016-07-03 10:10 +0200
Message-ID	<rQKDv-6iv-1@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <rQysF-7lA-1@gated-at.bofh.it> <rQA1r-8dk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> A few update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (2):
>>   Return directly after a failed kzalloc()
>>   Remove two OOM messages
>>
>>  drivers/input/serio/at32psif.c | 10 +++-------
>>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> What possible rationale is there for including this "references" header?
> 566ABCD9.1060404@users.sourceforge.net

Do any more software developers dare to reconsider source code
also around a jump label like "out"?


> This message id is for your message:
> 	"Source code review around jump label usage"
> sent December 11, 2015!

Can such an association with a bit of background information
be occasionally useful for clarification of corresponding
implementation details?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in  psif_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-02 21:10 +0200
  [PATCH 2/2] Input-at32psif: Remove OOM messages in psif_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-02 21:10 +0200
    Re: [PATCH 2/2] Input-at32psif: Remove OOM messages in  psif_probe() Julia Lawall <julia.lawall@lip6.fr> - 2016-07-02 21:30 +0200
  [PATCH 1/2] Input-at32psif: Return directly after a failed kzalloc()  in psif_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-02 21:10 +0200
  Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in  psif_probe() Joe Perches <joe@perches.com> - 2016-07-02 22:50 +0200
    Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in  psif_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-03 10:10 +0200

csiph-web