Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435875
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Philippe Reynes <tremyfr@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] net: ethernet: lantiq_etop: use phy_ethtool_{get|set}_link_ksettings |
| Date | Sun, 03 Jul 2016 00:10:01 +0200 |
| Message-ID | <rQBgR-FH-3@gated-at.bofh.it> (permalink) |
| References | <rQBgR-FH-1@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xAtCKops/n5YN/iDuoC2dlYWBt37pRb+VWi3jbckiPc=; b=j6JNGNoTC1TlEfJjeqqkPMLPvxH0Mn57a1ULY5JF79cZ9pZdCkgMK0IR+e4FaGSfyz hDAUZ5IwhwpqTRATcFlL2WlD1FER+xVlep0ZpkzX/aBXr9pKqj6FJDJf7+eMCXZPGFTE OiGO9g3TTPQh4zalFRGa2X0t/iCFKY9ojzbaTgDbdi4m4abjA7gqJDKNUXDzj+2gwuBs mPbOz1t4+wGpbK6oveexqjNH8tUDdK0gA0fNzHs3EaL7uhytArKfDuxUq4SvqvwLW90g 0kJC+ESMKtOTbc3XRbBUCqdSi87pa0wUvlPeGxfJximeTVirnCanTV/crbl/0WANwUq+ 6GIA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xAtCKops/n5YN/iDuoC2dlYWBt37pRb+VWi3jbckiPc=; b=Qd0FIaU9Thoekp1hzUHxr8husEJX9ZpwJbjHmZ1wTzAIqZiJXsdHMV12+y3D5TpBOj mle737oOqcQSkiQJGbcSRLxFHLipB+yPPmGYDDIOl1QG92lSYOp4zRZJguPdDV9Uiyn/ qdHJOgIfiUerlbVd0B+qIgRM527yZBDDaEp6R++fx+EcpyHKh7vs7/IDBP8u9gk2C1Hr Se1sOFxgsYJLe1jnw+zadIMg9uNy2LkmzKYcEtIX7U4pDsRGSUg/0eNA5KmIbNsKXhRq mHoRkoC+9oZiJyBaEK3AtpALn86rVDtmBYypC88qtgsO9dUZa0ffqYw+TeZGtN2b5aNG /gWQ== |
| X-Gm-Message-State | ALyK8tKpXo+6K5CZzLEeAZTqRaGxx+DJo4Vr1VCQaZTRHGo1ESjAhIzRExoftjnbJ4JO4Q== |
| X-Received | by 10.28.48.3 with SMTP id w3mr4208169wmw.28.1467497114123; Sat, 02 Jul 2016 15:05:14 -0700 (PDT) |
| X-Mailer | git-send-email 1.7.4.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 45 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe Reynes <tremyfr@gmail.com> |
| X-Original-Date | Sun, 3 Jul 2016 00:05:05 +0200 |
| X-Original-Message-ID | <1467497105-19935-2-git-send-email-tremyfr@gmail.com> |
| X-Original-References | <1467497105-19935-1-git-send-email-tremyfr@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1435875 |
Show key headers only | View raw
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.
Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
drivers/net/ethernet/lantiq_etop.c | 16 ++--------------
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index ad715a4..91e09d6 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -304,18 +304,6 @@ ltq_etop_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
}
static int
-ltq_etop_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
- return phy_ethtool_gset(dev->phydev, cmd);
-}
-
-static int
-ltq_etop_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
- return phy_ethtool_sset(dev->phydev, cmd);
-}
-
-static int
ltq_etop_nway_reset(struct net_device *dev)
{
return phy_start_aneg(dev->phydev);
@@ -323,9 +311,9 @@ ltq_etop_nway_reset(struct net_device *dev)
static const struct ethtool_ops ltq_etop_ethtool_ops = {
.get_drvinfo = ltq_etop_get_drvinfo,
- .get_settings = ltq_etop_get_settings,
- .set_settings = ltq_etop_set_settings,
.nway_reset = ltq_etop_nway_reset,
+ .get_link_ksettings = phy_ethtool_get_link_ksettings,
+ .set_link_ksettings = phy_ethtool_set_link_ksettings,
};
static int
--
1.7.4.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] net: ethernet: lantiq_etop: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-07-03 00:10 +0200
[PATCH 2/2] net: ethernet: lantiq_etop: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-07-03 00:10 +0200
Re: [PATCH 2/2] net: ethernet: lantiq_etop: use phy_ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2016-07-05 01:10 +0200
Re: [PATCH 1/2] net: ethernet: lantiq_etop: use phydev from struct net_device David Miller <davem@davemloft.net> - 2016-07-05 01:10 +0200
csiph-web