Re: [PATCH] [media] cec: add missing inline stubs

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] cec: add missing inline stubs
Date	2016-07-01 17:40 +0200
Message-ID	<rQ8HU-8mD-11@gated-at.bofh.it> (permalink)
References	<rQ4NX-60Z-11@gated-at.bofh.it> <rQ8ox-8fN-19@gated-at.bofh.it> <rQ8yd-8iZ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday, July 1, 2016 5:22:32 PM CEST Hans Verkuil wrote:
> > diff --git a/drivers/media/platform/vivid/Kconfig b/drivers/media/platform/vivid/Kconfig
> > index 8e6918c5c87c..8e31146d079a 100644
> > --- a/drivers/media/platform/vivid/Kconfig
> > +++ b/drivers/media/platform/vivid/Kconfig
> > @@ -26,6 +26,7 @@ config VIDEO_VIVID
> >  config VIDEO_VIVID_CEC
> >       bool "Enable CEC emulation support"
> >       depends on VIDEO_VIVID && MEDIA_CEC
> > +     depends on VIDEO_VIVID=m || MEDIA_CEC=y
> >       ---help---
> >         When selected the vivid module will emulate the optional
> >         HDMI CEC feature.
> > 
> > which is still not overly nice, but it manages to avoid the
> > IS_REACHABLE() check and it lets MEDIA_CEC be a module.
> 
> The only IS_REACHABLE is for the RC_CORE check, and that should remain.

I believe that is already taken care of by my earlier "[media] cec: add
RC_CORE dependency" patch, https://patchwork.linuxtv.org/patch/34892/
which seems to handle the dependency more gracefully (preventing nonsense
configurations rather than just not using RC_CORE).

> With my patch MEDIA_CEC can remain a module provided MEDIA_SUPPORT is also
> a module. All drivers depending on MEDIA_CEC also depend on MEDIA_SUPPORT,
> so that works.

To clarify, the problem with the option above is that VIDEO_VIVID_CEC
is a 'bool' option, and Kconfig lets that be turned on if both
VIDEO_VIVID and MEDIA_CEC are enabled, including the case where MEDIA_CEC
is a module and VIDEO_VIVID is not.

Your patch avoids that problem by making MEDIA_CEC a 'bool', my patch
above is an alternative by ensuring that VIDEO_VIVID_CEC cannot be
enabled if MEDIA_CEC is a module and VIDEO_VIVID is not.

	Arnd

Thread

[PATCH] [media] cec: add missing inline stubs Arnd Bergmann <arnd@arndb.de> - 2016-07-01 13:30 +0200
  Re: [PATCH] [media] cec: add missing inline stubs Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-01 16:40 +0200
    Re: [PATCH] [media] cec: add missing inline stubs Arnd Bergmann <arnd@arndb.de> - 2016-07-01 17:20 +0200
      Re: [PATCH] [media] cec: add missing inline stubs Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-01 17:30 +0200
        Re: [PATCH] [media] cec: add missing inline stubs Arnd Bergmann <arnd@arndb.de> - 2016-07-01 17:40 +0200
          Re: [PATCH] [media] cec: add missing inline stubs Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-01 19:40 +0200

csiph-web