Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel

From	Arnaldo Carvalho de Melo <acme@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel
Date	2016-07-01 16:50 +0200
Message-ID	<rQ7Vv-7Qe-29@gated-at.bofh.it> (permalink)
References	<rPWnn-Rf-1@gated-at.bofh.it> <rPWnn-Rf-3@gated-at.bofh.it> <rQ6Zs-7ge-19@gated-at.bofh.it> <rQ7Ca-7Jf-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu:
> > 在 2016年7月1日，下午9:40，Arnaldo Carvalho de Melo <acme@kernel.org> 写道：
> > I.e. perhaps evsel->overwrite is completely unnecessary and places
> > checking for it should instead check for evsel->attr.backward, no?
 
> If we remove evsel->overwrite, what should we set in parser? Make it
> directly setting attr?

yeah, is that possible? Trying... And then overwrite is how we chose to
expose this to the user, in the event syntax, but internally that means
using the backwards_ring buffer, right?

So this simplifies the code, removing information that was being
duplicated in evsel->overwrite and evsel->attr.write_backward.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel Wang Nan <wangnan0@huawei.com> - 2016-07-01 04:30 +0200
  Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old  kernel Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-01 15:50 +0200
    Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel pi3orama <pi3orama@163.com> - 2016-07-01 16:30 +0200
      Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old  kernel Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-07-01 16:50 +0200

csiph-web