Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

From	Dmitry Vyukov <dvyukov@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()
Date	2016-07-01 16:30 +0200
Message-ID	<rQ7Ca-7Jf-35@gated-at.bofh.it> (permalink)
References	<rQ7iO-7C4-15@gated-at.bofh.it> <rQ7st-7Fq-3@gated-at.bofh.it> <rQ7st-7Fq-1@gated-at.bofh.it> <rQ7st-7Fq-13@gated-at.bofh.it> <rQ7Ca-7Jf-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 1, 2016 at 4:18 PM, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>
> On 07/01/2016 05:15 PM, Dmitry Vyukov wrote:
>> On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>>> 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
>
>>>>> +
>>>>> +               if (obj_cache == cache)
>>>>> +                       qlist_put(to, qlink, cache->size);
>>>>> +               else
>>>>> +                       qlist_put(from, qlink, cache->size);
>>>>
>>>> This line is wrong. If obj_cache != cache, object size != cache->size.
>>>> Quarantine contains objects of different sizes.
>>>
>>> You're right. 11 pm is not good time to work. :/
>>> If it is fixed, the patch looks correct to you?
>>> I will fix it and send v4 on next week.
>>
>>
>> I don't see anything else wrong. But I need to see how you fix the size issue.
>> Performance of this operation is not particularly critical, so the
>> simpler the better.
>
> Is there any other way besides obvious: s/cache->size/obj_cache->size ?

We can remember the original bytes, then subtract
num_objects_moved*cache->size from it and assign to from->bytes.

Thread

[PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() js1304@gmail.com - 2016-07-01 16:10 +0200
  Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Joonsoo Kim <js1304@gmail.com> - 2016-07-01 16:20 +0200
    Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Dmitry Vyukov <dvyukov@google.com> - 2016-07-01 16:20 +0200
      Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Dmitry Vyukov <dvyukov@google.com> - 2016-07-01 16:30 +0200
        Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Joonsoo Kim <js1304@gmail.com> - 2016-07-01 16:40 +0200
  Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Dmitry Vyukov <dvyukov@google.com> - 2016-07-01 16:20 +0200
  Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-07-04 06:40 +0200

csiph-web