Re: [PATCH] sched: Assign !p->on_cpu to the second parameter of smp_cond_load_acquire()

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched: Assign !p->on_cpu to the second parameter of smp_cond_load_acquire()
Date	2016-07-01 10:50 +0200
Message-ID	<rQ2j8-4pm-5@gated-at.bofh.it> (permalink)
References	<rPXt7-1tk-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 01, 2016 at 11:08:01AM +0800, T.Zhou wrote:

> -	smp_cond_load_acquire(&p->on_cpu, !VAL);
> +	smp_cond_load_acquire(&p->on_cpu, !p->on_cpu);

Huh, what?! No, the second parameter should very much include VAL, which
gets assigned the value of *(&p->on_cpu).

Go read the macro, it even has a comment on.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched: Assign !p->on_cpu to the second parameter of  smp_cond_load_acquire() "T.Zhou" <t1zhou@163.com> - 2016-07-01 05:40 +0200
  Re: [PATCH] sched: Assign !p->on_cpu to the second parameter of  smp_cond_load_acquire() Peter Zijlstra <peterz@infradead.org> - 2016-07-01 10:50 +0200

csiph-web