[PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback
Date	Thu, 30 Jun 2016 03:30:01 +0200
Message-ID	<rPyXL-39e-1@gated-at.bofh.it> (permalink)
References	<rPyXL-39e-3@gated-at.bofh.it>
X-Original-To	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
X-Mailer	git-send-email 1.7.12.4
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.175.102.37]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A090202.577475E8.0072,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	59d5b7366519a776b7c164675216bc83
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, <z.liuxinliang@hisilicon.com>, <guohanjun@huawei.com>, <linux-acpi@vger.kernel.org>, <xuwei5@hisilicon.com>, <graeme.gregory@linaro.org>, Kefeng Wang <wangkefeng.wang@huawei.com>
X-Original-Date	Thu, 30 Jun 2016 09:27:41 +0800
X-Original-Message-ID	<1467250062-61583-2-git-send-email-wangkefeng.wang@huawei.com>
X-Original-References	<1467250062-61583-1-git-send-email-wangkefeng.wang@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1434140

Show key headers only | View raw

We can safely use dw8250_set_termios() as the default set_termios
callback instead of serial8250_do_set_termios(), so do it.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/tty/serial/8250/8250_dw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index e199696..65f3da7 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -301,7 +301,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
 		p->iotype = UPIO_MEM32;
 		p->regshift = 2;
 		p->serial_in = dw8250_serial_in32;
-		p->set_termios = dw8250_set_termios;
 		/* So far none of there implement the Busy Functionality */
 		data->uart_16550_compatible = true;
 	}
@@ -309,7 +308,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
 	/* Platforms with iDMA */
 	if (platform_get_resource_byname(to_platform_device(p->dev),
 					 IORESOURCE_MEM, "lpss_priv")) {
-		p->set_termios = dw8250_set_termios;
 		data->dma.rx_param = p->dev->parent;
 		data->dma.tx_param = p->dev->parent;
 		data->dma.fn = dw8250_idma_filter;
@@ -386,6 +384,7 @@ static int dw8250_probe(struct platform_device *pdev)
 	p->iotype	= UPIO_MEM;
 	p->serial_in	= dw8250_serial_in;
 	p->serial_out	= dw8250_serial_out;
+	p->set_termios	= dw8250_set_termios;
 
 	p->membase = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
 	if (!p->membase)
-- 
1.7.12.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-30 03:30 +0200

csiph-web