Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl options

From	Sean Young <sean@mess.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl options
Date	2016-06-30 01:00 +0200
Message-ID	<rPwCC-1DZ-9@gated-at.bofh.it> (permalink)
References	<rPnIZ-4Hd-3@gated-at.bofh.it> <rPnJ6-4Hd-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote:
> The Lirc framework works mainly with receivers, but there is
> nothing that prevents us from using it for transmitters as well.

The lirc interface already provides for transmitting IR.

> For that we need to have more control on the device frequency to
> set (which is a new concept fro LIRC) and we also need to provide
> to userspace, as feedback, the values of the used frequency and
> length.

Please can you elaborate on what exactly you mean by frequency and
length.

The carrier frequency can already be set with LIRC_SET_SEND_CARRIER.

> Add the LIRC_SET_LENGTH, LIRC_GET_FREQUENCY and
> LIRC_SET_FREQUENCY ioctl commands in order to allow the above
> mentioned operations.

You're also adding ioctls without any drivers implementing them
unless I missed something.

> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
>  include/uapi/linux/lirc.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/lirc.h b/include/uapi/linux/lirc.h
> index 4b3ab29..94a0d8c 100644
> --- a/include/uapi/linux/lirc.h
> +++ b/include/uapi/linux/lirc.h
> @@ -106,6 +106,7 @@
>  
>  /* code length in bits, currently only for LIRC_MODE_LIRCCODE */
>  #define LIRC_GET_LENGTH                _IOR('i', 0x0000000f, __u32)
> +#define LIRC_SET_LENGTH                _IOW('i', 0x00000010, __u32)

The LIRC_GET_LENGTH is specific to LIRCCODE encoding. Why are you
adding it here?

>  
>  #define LIRC_SET_SEND_MODE             _IOW('i', 0x00000011, __u32)
>  #define LIRC_SET_REC_MODE              _IOW('i', 0x00000012, __u32)
> @@ -165,4 +166,7 @@
>  
>  #define LIRC_SET_WIDEBAND_RECEIVER     _IOW('i', 0x00000023, __u32)
>  
> +#define LIRC_GET_FREQUENCY             _IOR('i', 0x00000024, __u32)
> +#define LIRC_SET_FREQUENCY             _IOW('i', 0x00000025, __u32)
> +
>  #endif
> -- 
> 2.8.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thread

[PATCH 00/15] lirc_dev fixes and beautification Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200
  [PATCH 15/15] include: lirc: add set length and frequency ioctl options Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200
    Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl  options Sean Young <sean@mess.org> - 2016-06-30 01:00 +0200
      Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl  options Andi Shyti <andi@etezian.org> - 2016-06-30 01:40 +0200
  [PATCH 11/15] lirc_dev: fix variable constant comparisons Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200
  [PATCH 07/15] lirc_dev: simplify if statement in lirc_add_to_buf Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200
  [PATCH 09/15] lirc_dev: merge three if statements in only one Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200

csiph-web