Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1434049
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation |
| Date | 2016-06-29 23:00 +0200 |
| Message-ID | <rPuKu-ts-21@gated-at.bofh.it> (permalink) |
| References | <rPlQR-3z0-9@gated-at.bofh.it> <rPlQR-3z0-7@gated-at.bofh.it> <rPrtf-72Q-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 29/06/2016 19:16, yunhong jiang wrote: >> > + start_sw_tscdeadline(apic); > IMHO, it's not good to start_sw_tscdeadline() on the start_hv_tscdeadline() > function. I think it's expected that the sw_timer is stopped when > start_hv_tscdeadline() returns successsfully, or sw_timer is not impacted if > start_hv_tscdeadline() fails. But it's not expected that start_hv_tscdeadline() > returns successfully while in fact it's the sw_timer started instead :) > > Would it be better to simply return failure here, and the caller then > starts the sw_timer? I agree with Yunhong. Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation Wanpeng Li <kernellwp@gmail.com> - 2016-06-29 13:30 +0200
Re: [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation yunhong jiang <yunhong.jiang@linux.intel.com> - 2016-06-29 19:30 +0200
Re: [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation Paolo Bonzini <pbonzini@redhat.com> - 2016-06-29 23:00 +0200
Re: [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation Wanpeng Li <kernellwp@gmail.com> - 2016-06-30 00:30 +0200
csiph-web