[PATCH 06/15] lirc_dev: do not use goto to create loops

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 06/15] lirc_dev: do not use goto to create loops
Date	2016-06-29 15:30 +0200
Message-ID	<rPnJ6-4Hd-45@gated-at.bofh.it> (permalink)
References	<rPnIZ-4Hd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

... use "do .. while" instead.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/media/rc/lirc_dev.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 400ab80..cc00b9a 100644
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -103,12 +103,11 @@ static int lirc_add_to_buf(struct irctl *ir)
 		 * service the device as long as it is returning
 		 * data and we have space
 		 */
-get_data:
-		res = ir->d.add_to_buf(ir->d.data, ir->buf);
-		if (res == 0) {
-			got_data++;
-			goto get_data;
-		}
+		do {
+			res = ir->d.add_to_buf(ir->d.data, ir->buf);
+			if (!res)
+				got_data++;
+		} while (!res);
 
 		if (res == -ENODEV)
 			kthread_stop(ir->task);
-- 
2.8.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 06/15] lirc_dev: do not use goto to create loops Andi Shyti <andi.shyti@samsung.com> - 2016-06-29 15:30 +0200

csiph-web