Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433664

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

From Manish Badarkhe <badarkhe.manish@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs
Date 2016-06-29 12:50 +0200
Message-ID <rPle9-36J-15@gated-at.bofh.it> (permalink)
References <rPk8p-2rm-3@gated-at.bofh.it> <rPk8p-2rm-1@gated-at.bofh.it> <rPle9-36J-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Keerthy,

sorry ignore my last two comments in previous mail.

On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe
<badarkhe.manish@gmail.com> wrote:
> Hi Keerthy
>
> Some minor comment
>
>> +static int lp873x_gpio_direction_output(struct gpio_chip *chip,
>> +                                       unsigned int offset, int value)
>> +{
>> +       struct lp873x_gpio *gpio = gpiochip_get_data(chip);
>> +
>> +       /* Set the initial value */
>> +       regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
>> +                          BIT(offset * 4), value ? BIT(offset * 4) : 0);
>> +
>> +       return 0;
>> +}

 Error needs to be return, this function always return 0.

 Regards
 Manish Badarkhe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs Keerthy <j-keerthy@ti.com> - 2016-06-29 11:40 +0200
  Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-06-29 12:50 +0200
    Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose  Outputs Keerthy <a0393675@ti.com> - 2016-06-29 14:50 +0200
  Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-06-29 12:50 +0200

csiph-web