[PATCH -v2 0/2] printk.kmsg: Ratelimit it by default

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	[PATCH -v2 0/2] printk.kmsg: Ratelimit it by default
Date	Wed, 29 Jun 2016 12:00:01 +0200
Message-ID	<rPkrL-2AI-9@gated-at.bofh.it> (permalink)
X-Original-To	Ingo Molnar <mingo@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Steven Rostedt <rostedt@goodmis.org>
X-Mailer	git-send-email 2.7.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Uwe Kleine-König <u.kleine-koenig@pengutronix.de>, Franck Bui <fbui@suse.com>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 29 Jun 2016 11:55:59 +0200
X-Original-Message-ID	<1467194161-1472-1-git-send-email-bp@alien8.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1433642

Show key headers only | View raw

From: Borislav Petkov <bp@suse.de>

Hi all,

here's v2 with the requested sysctl option kernel.printk_kmsg and
locking of the setting when printk.kmsg= is supplied on the command
line.

Patch 1 is unchanged.

Patch 2 has grown the sysctl addition.

Changelog:

v1:

Rostedt is busy so I took Linus' old patch and Steven's last v2 and
split and extended them with the comments people had on the last thread:

https://lkml.kernel.org/r/20160425145606.598329f2@gandalf.local.home

I hope, at least.

So it is ratelimiting by default, with "on" and "off" cmdline options. I
called the option somewhat a bit shorter too: "printk.kmsg"

The current use cases of this and of which I'm aware are:

* debug the kernel and thus shut up all interfering input from
userspace, i.e. boot with "printk.kmsg=off"

* debug userspace (and by that I mean systemd) by booting with
"printk.kmsg=on" so that the ratelimiting is disabled and the kernel log
gets all the spew.

Thoughts?

Thanks.

Borislav Petkov (2):
  ratelimit: Extend to print suppressed messages on release
  printk: Add kernel parameter to control writes to /dev/kmsg

 Documentation/kernel-parameters.txt |  6 +++
 Documentation/sysctl/kernel.txt     | 14 +++++++
 include/linux/printk.h              |  6 +++
 include/linux/ratelimit.h           | 36 ++++++++++++++---
 kernel/printk/printk.c              | 77 +++++++++++++++++++++++++++++++++----
 kernel/sysctl.c                     |  9 +++++
 lib/ratelimit.c                     |  6 ++-
 7 files changed, 139 insertions(+), 15 deletions(-)

-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -v2 0/2] printk.kmsg: Ratelimit it by default Borislav Petkov <bp@alien8.de> - 2016-06-29 12:00 +0200
  [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov <bp@alien8.de> - 2016-06-29 12:00 +0200
    Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Joe Perches <joe@perches.com> - 2016-06-29 12:30 +0200
      Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-06-29 16:30 +0200
    Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Ingo Molnar <mingo@kernel.org> - 2016-07-01 10:30 +0200
      Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-01 11:20 +0200
        Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Ingo Molnar <mingo@kernel.org> - 2016-07-01 12:40 +0200
        Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-01 12:40 +0200
        Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages  on release Ingo Molnar <mingo@kernel.org> - 2016-07-01 13:30 +0200
  [PATCH -v2 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-06-29 12:00 +0200
    Re: [PATCH -v2 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-07-01 11:20 +0200
      Re: [PATCH -v2 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Ingo Molnar <mingo@kernel.org> - 2016-07-01 12:40 +0200
    Re: [PATCH -v2 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Ingo Molnar <mingo@kernel.org> - 2016-07-01 11:20 +0200

csiph-web