Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433636
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag() |
| Date | 2016-06-29 11:50 +0200 |
| Message-ID | <rPki7-2xi-43@gated-at.bofh.it> (permalink) |
| References | <rOLNn-5kI-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Jun 2016 23:50:29 +0300
> There is a static checker warning here "warn: mask and shift to zero"
> and the code sets "ring" to zero every time. From looking at how
> QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
> qlcnic_83xx_hndl() should be removed.
>
> Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag() Dan Carpenter <dan.carpenter@oracle.com> - 2016-06-27 23:00 +0200 Re: [patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag() David Miller <davem@davemloft.net> - 2016-06-29 11:50 +0200
csiph-web