Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes
Date	2016-06-29 10:30 +0200
Message-ID	<rPj2G-1OB-21@gated-at.bofh.it> (permalink)
References	<rOFeV-XV-7@gated-at.bofh.it> <rP6Ia-2Di-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 2016-06-28 15:17:56, Steven Rostedt wrote:
> On Mon, 27 Jun 2016 15:54:33 +0200
> Petr Mladek <pmladek@suse.com> wrote:
> 
> > 1st patch adds one more paranoid check of the modified function on x86.
> > 
> > Plus there are 3 small changes that appeared when hunting down
> > the 1st patch.
> > 
> > Petr Mladek (4):
> >   ftrace/x86: Make sure to modify 5-bite instructions
> >   ftrace/x86: Do not crash when reading wrong ftrace func
> 
> The first two are mostly just "detect error, when it happens again"
> chanes.

Yup.

> >   ftrace: Always destroy trampoline when shutting down the trace
> >   ftrace: Fixup trace_selftest_ops()
> 
> These two seem to fix real bugs. I'm thinking they should go in now and
> be backported via stable.
> 
> Thoughts?

Makes sense. Should I do anything, please?

Best Regards,
Petr

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] ftrace: One more check on x86 and some small fixes Petr Mladek <pmladek@suse.com> - 2016-06-27 16:00 +0200
  [PATCH 3/4] ftrace: Always destroy trampoline when shutting down the trace Petr Mladek <pmladek@suse.com> - 2016-06-27 16:00 +0200
  [PATCH 2/4] ftrace/x86: Do not crash when reading wrong ftrace func Petr Mladek <pmladek@suse.com> - 2016-06-27 16:00 +0200
    Re: [PATCH 2/4] ftrace/x86: Do not crash when reading wrong ftrace  func Steven Rostedt <rostedt@goodmis.org> - 2016-06-27 16:50 +0200
      Re: [PATCH 2/4] ftrace/x86: Do not crash when reading wrong ftrace  func Petr Mladek <pmladek@suse.com> - 2016-06-28 12:10 +0200
  [PATCH 1/4] ftrace/x86: Make sure to modify 5-bite instructions Petr Mladek <pmladek@suse.com> - 2016-06-27 16:00 +0200
  [PATCH 4/4] ftrace: Fixup trace_selftest_ops() Petr Mladek <pmladek@suse.com> - 2016-06-27 16:00 +0200
  Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes Namhyung Kim <namhyung@gmail.com> - 2016-06-28 07:30 +0200
  Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes Steven Rostedt <rostedt@goodmis.org> - 2016-06-28 21:20 +0200
    Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes Petr Mladek <pmladek@suse.com> - 2016-06-29 10:30 +0200

csiph-web