Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433427
| From | Yakir Yang <ykk@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf |
| Date | 2016-06-29 05:40 +0200 |
| Message-ID | <rPew1-7lU-9@gated-at.bofh.it> (permalink) |
| References | <rMGf8-5Rv-9@gated-at.bofh.it> <rN25Y-329-9@gated-at.bofh.it> <rN5dv-5px-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Doug, On 06/23/2016 01:16 PM, Doug Anderson wrote: > Yakir, > > On Wed, Jun 22, 2016 at 6:58 PM, Yakir Yang <ykk@rock-chips.com> wrote: >> For RK3399's GRF module, if we want to operate the graphic related grf >> registers, we need to enable the pclk_vio_grf which supply power for VIO >> GRF IOs, so it's better to introduce an optional grf clock in driver. >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> --- >> Hi all, >> >> This is an external patch for analogix_dp misc cleanup thread [0] >> [0]: https://patchwork.kernel.org/patch/9175613/ >> >> BR, >> - Yakir >> >> Changes in v4.1: >> - Fix compiled error, sorry. >> "dp->cgfclk" --> 'dp->grfclk' >> >> Changes in v4: >> - Check the the error code properly, 'EPROBE_DEFER' should be returned, >> 'ENOENT' should assign a NULL point to grfclk, other errors should be >> regarded as failed. (Tomasz, Doug, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/351821/20/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@249] >> - Add the document about optional 'grf' clock (Tomasz, Doug, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/351821/] >> >> Changes in v3: >> - Add this patch in v3 >> >> .../display/rockchip/analogix_dp-rockchip.txt | 6 ++++++ >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 23 +++++++++++++++++++--- >> 2 files changed, 26 insertions(+), 3 deletions(-) > I probably would have split into two patches so the bindings was its > own patch, but I don't think it's strictly required. > > In any case, this seems good to me. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > This is not big change, so collect them into one patch should be more cleaner, thanks for your reviewed ;) >
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf Yakir Yang <ykk@rock-chips.com> - 2016-06-29 05:40 +0200
csiph-web