[PATCH 1/3] befs: avoid dereferencing dentry twice

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] befs: avoid dereferencing dentry twice
Date	2016-07-01 02:10 +0200
Message-ID	<rPUbT-7Nl-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

No need to dereference dentry twice to get the name when we already have
it stored in a local variable.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

3 more things I noticed while familiarizing myself with the code of this
filesystem. Enjoying very much learning how it works.

Thanks,
Luis

 fs/befs/linuxvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 619b998..6740b0d 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -179,7 +179,7 @@ befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
 		kfree(utfname);
 
 	} else {
-		ret = befs_btree_find(sb, ds, dentry->d_name.name, &offset);
+		ret = befs_btree_find(sb, ds, name, &offset);
 	}
 
 	if (ret == BEFS_BT_NOT_FOUND) {
-- 
2.5.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] befs: avoid dereferencing dentry twice Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-01 02:10 +0200
  [PATCH 3/3] befs: use simpler while loop Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-01 02:10 +0200
  [PATCH 2/3] befs: remove constant variable Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-01 02:10 +0200

csiph-web