Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1434905
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/7] net: ethernet: bgmac: Add platform device support |
| Date | 2016-07-01 01:30 +0200 |
| Message-ID | <rPTzb-7lm-3@gated-at.bofh.it> (permalink) |
| References | <rPT69-6Wn-13@gated-at.bofh.it> <rPTfQ-7eS-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[snip]
+
> + return 0;
> +
> +err2:
> + devm_iounmap(&pdev->dev, bgmac->plat.idm_base);
> +err1:
> + devm_iounmap(&pdev->dev, bgmac->plat.base);
> +err:
> + devm_kfree(&pdev->dev, bgmac);
This is not needed actually, now that you use the device managed helper
functions.
> +
> + return rc;
> +}
> +
> +static int bgmac_remove(struct platform_device *pdev)
> +{
> + struct bgmac *bgmac = platform_get_drvdata(pdev);
> +
> + bgmac_enet_remove(bgmac);
> + devm_iounmap(&pdev->dev, bgmac->plat.idm_base);
> + devm_iounmap(&pdev->dev, bgmac->plat.base);
> + devm_kfree(&pdev->dev, bgmac);
Same here.
--
Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] net: ethernet: bgmac: Add platform device support Jon Mason <jon.mason@broadcom.com> - 2016-07-01 01:10 +0200
[PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-01 01:10 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Rob Herring <robh@kernel.org> - 2016-07-01 05:00 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-01 16:30 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Arnd Bergmann <arnd@arndb.de> - 2016-07-01 11:50 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-01 17:20 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Arnd Bergmann <arnd@arndb.de> - 2016-07-01 17:50 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Ray Jui <ray.jui@broadcom.com> - 2016-07-04 18:40 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Arnd Bergmann <arnd@arndb.de> - 2016-07-05 15:40 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-06 01:20 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Arnd Bergmann <arnd@arndb.de> - 2016-07-06 09:40 +0200
Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-08 00:50 +0200
Re: [PATCH 5/7] net: ethernet: bgmac: Add platform device support Florian Fainelli <f.fainelli@gmail.com> - 2016-07-01 01:30 +0200
Re: [PATCH 0/7] net: ethernet: bgmac: Add platform device support Arnd Bergmann <arnd@arndb.de> - 2016-07-01 12:10 +0200
csiph-web