Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1434855

'perf test backward' failing with older kernels, should Skip

Show all headers | View raw

Hi Wang,

	I booted a machine with the f24 distro kernel and the backward
ring buffer test started FAILing, when it should've noticed that the
kernel doesn't support it and Skip instead:

[root@jouet ~]# perf test -v backward
45: Test backward reading from ring buffer                   :
--- start ---
<SNIP>
mmap size 1052672B
Unexpected counter: sample_count=0, comm_count=0
---- end ----
Test backward reading from ring buffer: FAILED!
[root@jouet ~]#


Ok, so I think the patch below should do the trick, is that right? With it
I get:

[root@jouet ~]# perf test backward
45: Test backward reading from ring buffer                   : Skip
[root@jouet ~]#

diff --git a/tools/perf/tests/backward-ring-buffer.c b/tools/perf/tests/backward-ring-buffer.c
index e70313fac5a5..0731b0bf9552 100644
--- a/tools/perf/tests/backward-ring-buffer.c
+++ b/tools/perf/tests/backward-ring-buffer.c
@@ -118,8 +118,10 @@ int test__backward_ring_buffer(int subtest __maybe_unused)
 	perf_evlist__config(evlist, &opts, NULL);
 
 	/* Set backward bit, ring buffer should be writing from end */
-	evlist__for_each_entry(evlist, evsel)
+	evlist__for_each_entry(evlist, evsel) {
+		evsel->overwrite = true;
 		evsel->attr.write_backward = 1;
+	}
 
 	err = perf_evlist__open(evlist);
 	if (err < 0) {

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

'perf test backward' failing with older kernels, should Skip Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-30 23:10 +0200
  Re: 'perf test backward' failing with older kernels, should Skip "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-01 04:00 +0200

csiph-web