Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1434724
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree |
| Date | 2016-06-30 18:30 +0200 |
| Message-ID | <rPN0J-3nZ-17@gated-at.bofh.it> (permalink) |
| References | <rPMem-2RC-15@gated-at.bofh.it> <rPKYV-2bo-9@gated-at.bofh.it> <rPKYV-2bo-7@gated-at.bofh.it> <rPMem-2RC-15@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Peter Zijlstra <peterz@infradead.org> wrote: > > + if (conn->proto.index_key < k.index_key) > > + p = p->rb_left; > > + else if (conn->proto.index_key > k.index_key) > > + p = p->rb_right; > > You still very much need rcu_dereference() for both left and right > pointers. As well as the first p load. Bah... Yes. Good point. > > + rb_link_node(&conn->service_node, parent, pp); > > You want rb_link_node_rcu() here. Should there be an rb_replace_node_rcu() also? David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree David Howells <dhowells@redhat.com> - 2016-06-30 16:20 +0200
Re: [PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree Peter Zijlstra <peterz@infradead.org> - 2016-06-30 17:40 +0200
Re: [PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree David Howells <dhowells@redhat.com> - 2016-06-30 18:30 +0200
Re: [PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree David Howells <dhowells@redhat.com> - 2016-06-30 18:50 +0200
Re: [PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree Peter Zijlstra <peterz@infradead.org> - 2016-06-30 22:30 +0200
csiph-web