Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

From	Dave Young <dyoung@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.
Date	2016-06-30 17:50 +0200
Message-ID	<rPMo2-2Vc-5@gated-at.bofh.it> (permalink)
References	<rMzQl-1Gf-3@gated-at.bofh.it> <rP9wm-4m4-33@gated-at.bofh.it> <rPtEL-8iu-49@gated-at.bofh.it> <rPv3Q-Q1-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote:
> Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young:
> > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote:
> > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young:
> > > > On 06/27/16 at 04:21pm, Dave Young wrote:
> > > > Using one argument for both sounds more reasonable than using a
> > > > separate
> > > > argument for memory walk..
> > > 
> > > I agree. This patch doesn't use a separate top_down argument, it's the
> > > same patch I sent earlier except that the comments to struct kexec_buf
> > > are in patch 2/9. What do you think?
> > 
> > It looks good except one nitpick inline..
> > 
> >
> > > +/**
> > > + * kexec_locate_mem_hole - find free memory to load segment or use in
> > > purgatory
>  
> > It is not necessary to use only for purgatory load..
> 
> Ok, what about this?
> 
> /**
>  * kexec_locate_mem_hole - find free memory in a given kimage.

Hmm, a given kimage sounds not correct, I can not get a better way to
describe it. How about below with a little change to your previous one:

kexec_locate_mem_hole - find a free chunk of memory to load kexec segment.
In powerpc the memory chunk can also be used for the purgatory stack.

Thanks
Dave

Thread

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-27 18:30 +0200
  Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-06-27 18:40 +0200
    Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-06-27 19:00 +0200
    Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-27 22:30 +0200
      Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-28 21:30 +0200
        Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-06-29 00:20 +0200
          Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-29 21:50 +0200
            Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-06-29 23:20 +0200
              Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-30 17:50 +0200
                Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-06-30 19:40 +0200
                Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from  kexec_add_buffer. Dave Young <dyoung@redhat.com> - 2016-06-30 23:40 +0200

csiph-web