Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1434531

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

Show all headers | View raw

On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote:
> On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote:
> > Add supports for 16k (wideband BT) and add a general compatible
> > string "linux,bt-sco"
> 
> This will claim that we support 16k on existing systems which we clearly
> don't.  It also seems unwise to advertise multiple rates when we've no
> way to configure the rates...  how does the BT controller figure out
> what the sample rate is?

The codec driver is a dummy driver for bt device and actually do
nothing. The user-space will control both bt part and alsa part (at
least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only
support 8k and was already there before the patch, but I think it might
be ok to extend it to 16k without any side effect.

If you worry about some potential risk (I don't see any) maybe we have
to develop another dummy bt-sco codec driver which support both 8k and
16k?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Mark Brown <broonie@kernel.org> - 2016-06-30 14:20 +0200
  Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-30 15:00 +0200
    Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Garlic Tseng <garlic.tseng@mediatek.com> - 2016-07-01 05:00 +0200
      Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Mark Brown <broonie@kernel.org> - 2016-07-01 18:20 +0200
        Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Chen-Yu Tsai <wens@csie.org> - 2016-07-02 11:20 +0200
          Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a  general compatible string Garlic Tseng <garlic.tseng@mediatek.com> - 2016-07-04 04:00 +0200

csiph-web