Re: [PATCHv2 0/7] eBPF JIT for PPC64

From	Andreas Ziegler <andreas.ziegler@fau.de>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 0/7] eBPF JIT for PPC64
Date	2016-06-30 11:10 +0200
Message-ID	<rPG8V-7It-11@gated-at.bofh.it> (permalink)
References	<rMTcl-5Ma-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Naveen,

this patchset makes a change to arch/powerpc/net/Makefile in order to only
compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use
bpf_jit_comp64.c if CONFIG_PPC64 is enabled.

Inside arch/powerpc/net/bpf_jit_comp.c, however, there is still an #ifdef
CONFIG_PPC64 block at line 667 (linux-next of today, i.e., next-20160630):

  #ifdef CONFIG_PPC64
                  /* Function descriptor nastiness: Address + TOC */
                  ((u64 *)image)[0] = (u64)code_base;
                  ((u64 *)image)[1] = local_paca->kernel_toc;
  #endif

From my understanding of the code, this #ifdef can now be removed, as there is
no way the file could be compiled with CONFIG_PPC64 enabled. Is this correct?

Best regards,

Andreas

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2 0/7] eBPF JIT for PPC64 Andreas Ziegler <andreas.ziegler@fau.de> - 2016-06-30 11:10 +0200
  Re: [PATCHv2 0/7] eBPF JIT for PPC64 Denis Kirjanov <kda@linux-powerpc.org> - 2016-06-30 11:40 +0200
    Re: [PATCHv2 0/7] eBPF JIT for PPC64 "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-06-30 12:40 +0200

csiph-web