Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch removed from -mm tree

From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch removed from -mm tree
Date	2016-06-30 09:40 +0200
Message-ID	<rPEJQ-6JB-13@gated-at.bofh.it> (permalink)
References	<rPiJk-1HZ-11@gated-at.bofh.it> <rPiJk-1HZ-9@gated-at.bofh.it> <rPkBs-2SX-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 29, 2016 at 12:05:09PM +0200, Vlastimil Babka wrote:
> On 06/29/2016 10:12 AM, Joonsoo Kim wrote:
> >>@@ -1035,8 +1034,12 @@ static void isolate_freepages(struct com
> >> 			continue;
> >>
> >> 		/* Found a block suitable for isolating free pages from. */
> >>-		isolate_freepages_block(cc, &isolate_start_pfn,
> >>-					block_end_pfn, freelist, false);
> >>+		isolated = isolate_freepages_block(cc, &isolate_start_pfn,
> >>+						block_end_pfn, freelist, false);
> >>+		/* If isolation failed early, do not continue needlessly */
> >>+		if (!isolated && isolate_start_pfn < block_end_pfn &&
> >>+		    cc->nr_migratepages > cc->nr_freepages)
> >>+			break;
> >
> >Hello, David.
> >
> >Minchan found the bug on this patch.
> 
> Was it reported in some mail to linux-mm before the patch was sent
> to Linus, or just now?

Unfortunately, we found it yesterday and discussed it in offline.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch  removed from -mm tree Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-06-29 10:10 +0200
  Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch  removed from -mm tree Vlastimil Babka <vbabka@suse.cz> - 2016-06-29 12:10 +0200
    Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch  removed from -mm tree Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-06-30 09:40 +0200

csiph-web