Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433261

Re: [PATCH] phy: xgene: rename "enum phy_mode" to "enum xgene_phy_mode"

Show all headers | View raw

Hi,

> commit 96284c53246f ("phy: Add set_mode callback") introduced
> enum phy_mode in phy_core. This introduced the following build
> error.
>
> drivers/phy/phy-xgene.c:521:6: error: nested redefinition of 'enum phy_mode'
>  enum phy_mode {
>       ^
> drivers/phy/phy-xgene.c:521:6: error: redeclaration of 'enum phy_mode'
> In file included from drivers/phy/phy-xgene.c:57:0:
> include/linux/phy/phy.h:25:6: note: originally defined here
>  enum phy_mode {
>       ^
> Fix it here.
>
> Fixes: 96284c53246f ("phy: Add set_mode callback")
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

You can add my:

Reviewed-by: Loc Ho <lho@apm.com>

-Loc

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: xgene: rename "enum phy_mode" to "enum xgene_phy_mode" Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-28 11:30 +0200
  Re: [PATCH] phy: xgene: rename "enum phy_mode" to "enum xgene_phy_mode" Loc Ho <lho@apm.com> - 2016-06-28 22:00 +0200

csiph-web