Re: [PATCH] lpfc: Fix possible NULL pointer dereference

From	Tyrel Datwyler <turtle.in.the.kernel@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lpfc: Fix possible NULL pointer dereference
Date	2016-06-28 22:30 +0200
Message-ID	<rP7NT-3gG-33@gated-at.bofh.it> (permalink)
References	<rKiJX-2Ya-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/15/2016 06:00 AM, Johannes Thumshirn wrote:
> Check for the existance of pciob->vport before accessing it.

piocb mispelled.

> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>  drivers/scsi/lpfc/lpfc_sli.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 70edf21..134078f 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -1329,15 +1329,10 @@ lpfc_sli_ringtxcmpl_put(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
>  	if ((unlikely(pring->ringno == LPFC_ELS_RING)) &&
>  	   (piocb->iocb.ulpCommand != CMD_ABORT_XRI_CN) &&
>  	   (piocb->iocb.ulpCommand != CMD_CLOSE_XRI_CN) &&
> -	 (!(piocb->vport->load_flag & FC_UNLOADING))) {
> -		if (!piocb->vport)
> -			BUG();

Granted the previous code would crash and burn in the if statement prior
to the BUG() assertion if piocb->vport was NULL, but is the condition
!piocb->vport still a bug here? Should that case still be asserted?

-Tyrel

> -		else
> -			mod_timer(&piocb->vport->els_tmofunc,
> -				jiffies +
> -				msecs_to_jiffies(1000 * (phba->fc_ratov << 1)));
> -	}
> -
> +	    piocb->vport && !(piocb->vport->load_flag & FC_UNLOADING))
> +		mod_timer(&piocb->vport->els_tmofunc,
> +			  jiffies +
> +			  msecs_to_jiffies(1000 * (phba->fc_ratov << 1)));
>  
>  	return 0;
>  }
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] lpfc: Fix possible NULL pointer dereference Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2016-06-28 22:30 +0200
  Re: [PATCH] lpfc: Fix possible NULL pointer dereference Johannes Thumshirn <jthumshirn@suse.de> - 2016-07-05 14:40 +0200

csiph-web