Re: [PATCH v6] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs
Date	2016-06-28 16:30 +0200
Message-ID	<rP2bv-8gz-3@gated-at.bofh.it> (permalink)
References	<rMrSN-579-15@gated-at.bofh.it> <rOZ3X-6bg-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 28, 2016 at 12:06:22PM +0100, Will Deacon wrote:
> On Tue, Jun 21, 2016 at 12:12:36PM +0100, Suzuki K Poulose wrote:
> > +static struct attribute_group cpuregs_attr_group = {
> > +	.attrs = cpuregs_attrs,
> > +	.name = "identification"
> > +};
> 
> This makes sense because MIDR/REVIDR belong to the "Identification"
> functional group of registers, however I wonder if we should put this
> under a directory called "regs" or similar, so that we don't have a
> confusing top-level directory where "identification" lives alongside
> things like "hotplug" and "cpuidle".

IMO, there are too many subdirectories and I don't think we would expose
any other registers than the ID ones.

-- 
Catalin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to  sysfs Will Deacon <will.deacon@arm.com> - 2016-06-28 13:10 +0200
  Re: [PATCH v6] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to  sysfs Catalin Marinas <catalin.marinas@arm.com> - 2016-06-28 16:30 +0200

csiph-web