Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

From	Bob Copeland <me@bobcopeland.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template
Date	2016-06-28 16:20 +0200
Message-ID	<rP21P-8cR-5@gated-at.bofh.it> (permalink)
References	<rOZdD-6hk-3@gated-at.bofh.it> <rOZdD-6hk-5@gated-at.bofh.it> <rOZdD-6hk-7@gated-at.bofh.it> <rOZdD-6hk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 28, 2016 at 02:13:06PM +0300, Yaniv Machani wrote:
> From: Meirav Kama <meiravk@ti.com>
> 
> There are several values in HT info elements of mesh beacon (built by the
> mac80211) that are incorrect.

Would be good to enumerate the problems here.

> To fix them:
> 1. mac80211 will check configuration from cfg and will build accordingly.
> 2. changes made in mesh default values.

What is wrong with the defaults?

>  	sband = local->hw.wiphy->bands[band];
>  	if (!sband->ht_cap.ht_supported ||
> @@ -431,11 +433,40 @@ int mesh_add_ht_cap_ie(struct ieee80211_sub_if_data *sdata,
>  	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
>  		return 0;
>  
> +    /* determine capability flags */
> +	cap = sband->ht_cap.cap;

There is some weird whitespace here (space instead of tabs for the
comment).

-- 
Bob Copeland %% http://bobcopeland.com/

Thread

[PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Yaniv Machani <yanivma@ti.com> - 2016-06-28 13:20 +0200
  Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Bob Copeland <me@bobcopeland.com> - 2016-06-28 16:20 +0200
  Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Johannes Berg <johannes@sipsolutions.net> - 2016-06-29 09:20 +0200

csiph-web