Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432950

[PATCH v6 5/6] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate

Show all headers | View raw

mfd_add_devices enables parsing device tree nodes without compatibles
for regulators and gpio modules. Replace of_platform_populate with
mfd_add_devices. mfd_cell currently is populated with regulators,
gpio and powerbutton.

Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Changes in v4:

  * Regrouped the mfd cells better.

 drivers/mfd/tps65218.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 9bca1b1..13834a0 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -33,6 +33,18 @@
 
 #define TPS65218_PASSWORD_REGS_UNLOCK   0x7D
 
+static const struct mfd_cell tps65218_cells[] = {
+	{
+		.name = "tps65218-pwrbutton",
+		.of_compatible = "ti,tps65218-pwrbutton",
+	},
+	{
+		.name = "tps65218-gpio",
+		.of_compatible = "ti,tps65218-gpio",
+	},
+	{ .name = "tps65218-regulator", },
+};
+
 /**
  * tps65218_reg_write: Write a single tps65218 register.
  *
@@ -245,8 +257,10 @@ static int tps65218_probe(struct i2c_client *client,
 
 	tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
 
-	ret = of_platform_populate(client->dev.of_node, NULL, NULL,
-				   &client->dev);
+	ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells,
+			      ARRAY_SIZE(tps65218_cells), NULL, 0,
+			      regmap_irq_get_domain(tps->irq_data));
+
 	if (ret < 0)
 		goto err_irq;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/6]  mfd: tps65218: Clean ups Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200
  [PATCH v6 5/6]  mfd: tps65218: Use mfd_add_devices instead of  of_platform_populate Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200
  [PATCH v6 3/6] input: tps65218-pwrbutton: Add platform_device_id table Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200
    Re: [PATCH v6 3/6] input: tps65218-pwrbutton: Add platform_device_id  table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-06-28 19:10 +0200
  [PATCH v6 6/6] regulator: tps65218: Remove all the compatibles Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200
  [PATCH v6 2/6] Documentation: regulator: tps65218: Update examples Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200
  [PATCH v6 1/6] mfd: tps65218: Remove redundant read wrapper Keerthy <j-keerthy@ti.com> - 2016-06-28 14:40 +0200

csiph-web