Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery

From	Evgeniy Polyakov <zbr@ioremap.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery
Date	2016-06-28 15:10 +0200
Message-ID	<rP0W5-7u6-5@gated-at.bofh.it> (permalink)
References	<rNzbA-6g-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Aaron

24.06.2016, 16:07, "Aaron Campbell" <aaron@monkey.org>:
> The proc connector messages include a sequence number, allowing userspace
> programs to detect lost messages. However, performing this detection is
> currently more difficult than necessary, since netlink messages can be
> delivered to the application out-of-order. To fix this, leave pre-emption
> disabled during cn_netlink_send(), and use GFP_NOWAIT.
>
> The following was written as a test case. Building the kernel w/ make -j32
> proved a reliable way to generate out-of-order cn_proc messages.

This is not actually about out-of-order sending which is impossible iirc,
but the way fork pushes messages into socket queue in parallel. What you've done
is syncing one more layer higher.

I'm not against this patch if you think it does fix some issues, but wording is not correct imo.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] connector: fix out-of-order cn_proc netlink message delivery Aaron Campbell <aaron@monkey.org> - 2016-06-24 15:20 +0200
  Re: [PATCH] connector: fix out-of-order cn_proc netlink message  delivery David Miller <davem@davemloft.net> - 2016-06-28 14:50 +0200
  Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery Evgeniy Polyakov <zbr@ioremap.net> - 2016-06-28 15:10 +0200

csiph-web