Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432926

Re: [PATCH] PM / devfreq: exynos-ppmu: fix error path in exynos_ppmu_probe()

From Chanwoo Choi <cwchoi00@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] PM / devfreq: exynos-ppmu: fix error path in exynos_ppmu_probe()
Date 2016-06-28 14:20 +0200
Message-ID <rP09H-6V8-11@gated-at.bofh.it> (permalink)
References <rOZnk-6lK-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

2016-06-28 20:21 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> iounmap() needs to be called in case of memory allocation
> (for devfreq-event devices) failure.  Fix it.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/devfreq/event/exynos-ppmu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index f312485..845bf25 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -482,7 +482,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>         if (!info->edev) {
>                 dev_err(&pdev->dev,
>                         "failed to allocate memory devfreq-event devices\n");
> -               return -ENOMEM;
> +               ret = -ENOMEM;
> +               goto err;
>         }
>         edev = info->edev;
>         platform_set_drvdata(pdev, info);
> --
> 1.9.1
>

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Also, this patch fix the bug. So, this patch should be included in v4.7-rc.

Thanks,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PM / devfreq: exynos-ppmu: fix error path in  exynos_ppmu_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-06-28 13:30 +0200
  [PATCH] PM / devfreq: exynos: fix error path in exynos_bus_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-06-28 13:30 +0200
    Re: [PATCH] PM / devfreq: exynos: fix error path in exynos_bus_probe() Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-28 14:10 +0200
  Re: [PATCH] PM / devfreq: exynos-ppmu: fix error path in exynos_ppmu_probe() Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-28 14:20 +0200

csiph-web