Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.
Date	2016-06-27 10:10 +0200
Message-ID	<rOzMd-62T-5@gated-at.bofh.it> (permalink)
References	<rMoBA-2OV-31@gated-at.bofh.it> <rMpnY-3mT-39@gated-at.bofh.it> <rOzCx-5JR-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, June 27, 2016 9:56:13 AM CEST Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
> 
> > diff --git a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > index 658f696..7dcbe65 100644
> > --- a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > +++ b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > @@ -25,7 +25,11 @@
> >  #define __O_NOFOLLOW 0100000
> >  #define __O_DIRECT   0200000
> >  
> > -#define __O_LARGEFILE        0
> > +#ifdef __ILP32__
> > +# define __O_LARGEFILE       0400000
> > +#else
> > +# define __O_LARGEFILE       0
> > +#endif
> 
> Is there any point in defining O_LARGEFILE to non-zero if the kernel is
> enforcing it anyway?

The kernel might want to return -EINVAL for undefined flags. I'm not
sure if we want to do that here, but it would seem like a correct
return code.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories. Andreas Schwab <schwab@suse.de> - 2016-06-27 10:00 +0200
  Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories. Arnd Bergmann <arnd@arndb.de> - 2016-06-27 10:10 +0200

csiph-web