Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device

From	Tobias Klauser <tklauser@distanz.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device
Date	2016-06-27 08:50 +0200
Message-ID	<rOywN-56U-9@gated-at.bofh.it> (permalink)
References	<rNWUx-6C6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-06-25 at 16:33:41 +0200, Philippe Reynes <tremyfr@gmail.com> wrote:
> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phy in the private structure, and update the driver to use the
> one contained in struct net_device.

In that case the phy member should also be removed from the definition
of private struct ethoc in the same patch.

Otherwise the patch looks good to me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-06-25 16:40 +0200
  [PATCH 2/2] net: ethernet: ethoc: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-06-25 16:40 +0200
    Re: [PATCH 2/2] net: ethernet: ethoc: use  phy_ethtool_{get|set}_link_ksettings Tobias Klauser <tklauser@distanz.ch> - 2016-06-27 08:50 +0200
  Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct  net_device Max Filippov <jcmvbkbc@gmail.com> - 2016-06-25 20:40 +0200
  Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct  net_device Tobias Klauser <tklauser@distanz.ch> - 2016-06-27 08:50 +0200

csiph-web