Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431679

Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

Show all headers | View raw

Hi Paul,

On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> menuconfig PM_DEVFREQ_EVENT
> 	bool "DEVFREQ-Event device Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/devfreq/devfreq-event.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-25 20:50 +0200
  Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-27 04:30 +0200

csiph-web