Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on stack overflow

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on stack overflow
Date	2016-06-26 19:10 +0200
Message-ID	<rOlJf-5Em-21@gated-at.bofh.it> (permalink)
References	<rNqUF-3pa-3@gated-at.bofh.it> <rNqUH-3pa-39@gated-at.bofh.it> <rNBn4-1op-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 24, 2016 at 8:35 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Thu, Jun 23, 2016 at 09:23:08PM -0700, Andy Lutomirski wrote:
>> If we overflow the stack, print_context_stack will abort.  Detect
>> this case and rewind back into the valid part of the stack so that
>> we can trace it.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>

FWIW, I'm making a trivial change here for v4: task->stack ->
task_stack_page(task).  Since it seems inconsequential, I'm keeping
your reviewed-by.

> --
> Josh



-- 
Andy Lutomirski
AMA Capital Management, LLC

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on stack overflow Andy Lutomirski <luto@kernel.org> - 2016-06-24 06:30 +0200
  Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace  on stack overflow Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-24 17:40 +0200
    Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on  stack overflow Andy Lutomirski <luto@amacapital.net> - 2016-06-26 19:10 +0200

csiph-web