Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431384

[PATCH] perf tools: Fix compiler error due to header file changes

Show all headers | View raw

The commit 41840d211c51 ("perf config: Move config declarations from
util/cache.h to util/config.h") moved perf_config*(), causes the
following errors when we build with LIBBABELTRACE=1:

  util/data-convert-bt.c: In function ‘convert__config’:
  util/data-convert-bt.c:1269:3: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
     c->queue_size = perf_config_u64(var, value);
     ^
  util/data-convert-bt.c:1269:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
  util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
  util/data-convert-bt.c:1302:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
    perf_config(convert__config, &c);
    ^

Include the right header file to fix this.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/data-convert-bt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 4b59879..7b1bc24 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -26,6 +26,7 @@
 #include "evlist.h"
 #include "evsel.h"
 #include "machine.h"
+#include "config.h"
 
 #define pr_N(n, fmt, ...) \
 	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)
-- 
1.8.5.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] perf tools: Fix compiler error due to header file changes He Kuang <hekuang@huawei.com> - 2016-06-26 10:50 +0200

csiph-web