Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date	2016-06-28 11:20 +0200
Message-ID	<rOXlw-4Xa-7@gated-at.bofh.it> (permalink)
References	<rObgS-7hv-5@gated-at.bofh.it> <rOzsR-5Gs-21@gated-at.bofh.it> <rOKxZ-4Bc-43@gated-at.bofh.it> <rOUQG-3cY-31@gated-at.bofh.it> <rOWSt-4vW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/06/16 11:47, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-27 23:36:26)
>> On 27/06/16 22:30, Stephen Boyd wrote:
>>>
>>> The VBUS notification is done through another piece of hardware. In this
>>> case it's done by the charger module. I've sent a patch for that[1].
>>
>> Isn't it better if ID event is handled as well in that PMIC driver instead of
>> creating a separate one here?
>>
>> Why do you need ID to be handled outside of the PMIC driver?
>> You mentioned earlier that some Qualcomm PMICs have ID detection.
>
> Sorry I must have confused you. There are two modules in the PMIC that
> are doing detection here. The charger module is detecting the VBUS event
> and this misc module is detecting the ID pin. I'm not sure why they're
> two different blocks, but it is what it is in the hardware.
> 
OK. Can the MISC block do anything else other than USB ID?
Does the USB ID interrupt come on a different line than the charger interrupt?

It would be more like MISC block interrupt than USB ID interrupt right?

cheers,
-roger

Thread

[PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-26 08:00 +0200
  Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-26 13:30 +0200
  Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-26 13:30 +0200
    Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Chanwoo Choi <cwchoi00@gmail.com> - 2016-06-28 14:10 +0200
      Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-29 08:30 +0200
        Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-29 20:50 +0200
          Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-30 02:40 +0200
            Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-30 03:10 +0200
  Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Roger Quadros <rogerq@ti.com> - 2016-06-27 09:50 +0200
    Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-27 21:40 +0200
      Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Roger Quadros <rogerq@ti.com> - 2016-06-28 08:40 +0200
        Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-28 10:50 +0200
          Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Roger Quadros <rogerq@ti.com> - 2016-06-28 11:20 +0200
            Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-29 00:10 +0200
              Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection  hardware Roger Quadros <rogerq@ti.com> - 2016-06-29 08:20 +0200
                Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-29 21:00 +0200

csiph-web